Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement array shapes for Preg::match $matches by-ref parameter #24

Closed
wants to merge 5 commits into from
Closed

Implement array shapes for Preg::match $matches by-ref parameter #24

wants to merge 5 commits into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 21, 2024 •
edited
Loading

staabm
staabm commented Jun 21, 2024
View reviewed changes
composer.json
@@ -20,8 +20,8 @@
"php": "^7.4 || ^8.0"
},
"require-dev": {
"symfony/phpunit-bridge": "^5",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to run the phpstan TypeInferenceTestCase with the simple bridge.

is the bridge vital for this repo, or can we use plain phpunit?

@staabm staabm mentioned this pull request Jun 21, 2024
Merged
staabm
staabm commented Jun 21, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@staabm staabm mentioned this pull request Jun 22, 2024
Closed
@Seldaek
Copy link
Member

Seldaek commented Jun 24, 2024

I won't have time to look in depth at this for a while but just wanted to say thanks already for even looking at doing it 🙏🏻

@Seldaek Seldaek closed this Jul 11, 2024
@staabm staabm deleted the stan-setup branch July 11, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @Seldaek